REF/BUG: Index.get_value called incorrectly, de-duplicate+simplify #31134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 19, 2020
| return self._get_values_for_loc(series, loc) | ||
|
|
||
| def _get_values_for_loc(self, series, loc): | ||
| """ |
There was a problem hiding this comment.
add Paramters / Returns & typing as much as you can.
This likely duplicates some existing routines, no?
There was a problem hiding this comment.
No, it de-duplicates code that we have I think in two places in Index.get_value and one each in DTI and TDI.
That said, this is one of the things we'll be able to simplify if/when we do the _values thing mentioned in #31037.
Will annotate in next pass
jreback
added
the
Indexing
jreback
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also engine.get_value is being called incorrectly in DTI/TDI, which this fixes.