Skip to content

TYP/CLN: Replaced "Optional[Hashable]" with "Label" from pandas._typing #31062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

TYP/CLN: Replaced "Optional[Hashable]" with "Label" from pandas._typing #31062

merged 1 commit into from
Jan 16, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Jan 16, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@ShaharNaveh ShaharNaveh added the Typing type annotations, mypy/pyright type checking label Jan 16, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 16, 2020
@simonjayhawkins simonjayhawkins merged commit 22fe19c into pandas-dev:master Jan 16, 2020
@simonjayhawkins
Copy link
Member

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CLN/TYP-Label branch January 16, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaharNaveh @simonjayhawkins