-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: correct wrong error message in df.pivot when columns=None #30925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 1314059
fix conflicts
charlesdong1991 8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 776e9ae
Merge remote-tracking branch 'upstream/master' into fix_issue_21425
charlesdong1991 4895497
correct error message
charlesdong1991 f4380cd
code change on Simon review
charlesdong1991 e60ffee
update test
charlesdong1991 61ac061
Merge remote-tracking branch 'upstream/master' into fix_issue_21425
charlesdong1991 d03452f
add whatsnew
charlesdong1991 abce670
change to typeerror and resolve conflict and merge master
charlesdong1991 28d3d41
fix conflict
charlesdong1991 c650a05
better whatsnew
charlesdong1991 16478e5
remove re
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,6 @@ | ||||||
from datetime import date, datetime, timedelta | ||||||
from itertools import product | ||||||
import re | ||||||
|
||||||
import numpy as np | ||||||
import pytest | ||||||
|
@@ -781,6 +782,15 @@ def test_pivot_with_list_like_values_nans(self, values, method): | |||||
expected = DataFrame(data=data, index=index, columns=columns, dtype="object") | ||||||
tm.assert_frame_equal(result, expected) | ||||||
|
||||||
def test_pivot_columns_none_raise_error(self): | ||||||
# GH 30924 | ||||||
df = pd.DataFrame( | ||||||
{"col1": ["a", "b", "c"], "col2": [1, 2, 3], "col3": [1, 2, 3]} | ||||||
) | ||||||
msg = re.escape("pivot() missing 1 required argument: 'columns'") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Minor nit but just use raw strings no need to import re for this |
||||||
with pytest.raises(TypeError, match=msg): | ||||||
df.pivot(index="col1", values="col3") | ||||||
|
||||||
@pytest.mark.xfail( | ||||||
reason="MultiIndexed unstack with tuple names fails with KeyError GH#19966" | ||||||
) | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reads a little better