Skip to content

API: Limit assert_*_equal functions in public API #30820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

API: Limit assert_*_equal functions in public API #30820

merged 1 commit into from
Jan 8, 2020

Conversation

TomAugspurger
Copy link
Contributor

As discussed on today's call. Just adding assert_extension_array_equal relative to 0.25.

@TomAugspurger TomAugspurger added this to the 1.0 milestone Jan 8, 2020
@jbrockmendel
Copy link
Member

LGTM

@TomAugspurger TomAugspurger merged commit d5046d4 into pandas-dev:master Jan 8, 2020
@TomAugspurger TomAugspurger deleted the testing-api branch January 8, 2020 22:33
@jorisvandenbossche
Copy link
Member

Looking at the assert_extension_array_equal code, we probably want to dispatch from there to the more specialized asserts for our known extension arrays (categorical, interval, datetime, etc).

Also, do we want to have an assert_array_equal that can handle both extension arrays and numpy arrays?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
API Design
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TomAugspurger @jbrockmendel @jorisvandenbossche @WillAyd