Skip to content

BUG: TDI.insert with empty TDI raising IndexError #30757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 9, 2020
Merged

BUG: TDI.insert with empty TDI raising IndexError #30757

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c613f2e
BUG: TDI.insert with empty TDI raising IndexError
jbrockmendel Jan 6, 2020
c4a1b3a
mypy fixup
jbrockmendel Jan 6, 2020
b8895e7
fix coercion test
jbrockmendel Jan 6, 2020
6be32da
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Jan 7, 2020
40f00b9
troubleshoot mypy
jbrockmendel Jan 7, 2020
29f26f3
remove unused import
jbrockmendel Jan 7, 2020
3c8f6fd
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Jan 8, 2020
c203c2c
troubleshoot mypy
jbrockmendel Jan 8, 2020
5a6def3
troubleshoot mypy
jbrockmendel Jan 8, 2020
d2a1459
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/tests/indexes/timedeltas/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,15 @@ def test_take_fill_value(self):


class TestTimedeltaIndex:
def test_insert_empty(self):
# Corner case inserting with length zero doesnt raise IndexError
idx = timedelta_range("1 Day", periods=3)
td = idx[0]

idx[:0].insert(0, td)
idx[:0].insert(1, td)
idx[:0].insert(-1, td)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth comparing the results

def test_insert(self):

idx = TimedeltaIndex(["4day", "1day", "2day"], name="idx")
Expand Down