REF: share _union between DTI/TDI #30714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 5, 2020
| @@ -806,6 +806,25 @@ def _fast_union(self, other, sort=None): | |||
| else: | |||
| return left | |||
|
|
|||
| def _union(self, other, sort): | |||
There was a problem hiding this comment.
other can a Union[DTI, TDI]
There was a problem hiding this comment.
@simonjayhawkins what's the preferred way of typing as type(self)?
There was a problem hiding this comment.
def _union(self: _T, other: Type[_T], sort):
There was a problem hiding this comment.
where does _T come from? I dont see this pattern anywhere else in the code
There was a problem hiding this comment.
i vote for merging and adding annotations in follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.