STY: Spaces over concat strings - batch 1 #30707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally prefer the spaces at the start of the strings. I find it easier to spot missing spaces. not sure what others think. |
|
No strong preference but I think OK. @MomIsBestFriend can you merge master? |
added 2 commits
January 6, 2020 12:03
datapythonista
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
I'm more used to spaces at the end, but whatever it is, I think it's good to have a convention.
This comes from this new guide: https://dev.pandas.io/docs/development/code_style.html#id6 I think the standard started from a discussion in a review.
This PR lgtm, happy to get it merged. But also ok on reopening the discussion if the discussion when merging the style guide wasn't visible enough.
WillAyd
approved these changes
Jan 6, 2020
|
Thanks @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff