TST: Adding test to concat Sparse arrays #30645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@SdgJlbl Thanks for the PR. suggested change works for me on windows. hopefully won't break other builds
pandas/tests/reshape/test_concat.py
Outdated
| # GH 23557 | ||
| a = pd.Series(pd.SparseArray([0, 1, 2])) | ||
| expected = pd.DataFrame(data=[[0, 0], [1, 1], [2, 2]]).astype( | ||
| pd.SparseDtype("int", 0) |
There was a problem hiding this comment.
Suggested change
| pd.SparseDtype("int", 0) | |
| pd.SparseDtype(np.intp, 0) |
There was a problem hiding this comment.
Thanks for the suggestion, I've amended the PR with the change
There was a problem hiding this comment.
I had to change this to np.int64 else the tests were failing on linux 32-bit
simonjayhawkins
added
Sparse
SdgJlbl
force-pushed
the
gh-23557-test-sparse-concat
branch
from
3cf64cb to
36e171c
Compare
jreback
reviewed
Jan 4, 2020
pandas/tests/reshape/test_concat.py
Outdated
|
|
||
| def test_concat_sparse(): | ||
| # GH 23557 | ||
| a = pd.Series(pd.SparseArray([0, 1, 2])) |
There was a problem hiding this comment.
can you add
from pandas.array import SparseArrary
at the top instead of directly using SparseArray as we are doing to deprecate that import.
SdgJlbl
force-pushed
the
gh-23557-test-sparse-concat
branch
from
36e171c to
93e3cc7
Compare
|
thanks @SdgJlbl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff