-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DEPR: Deprecate numpy argument in read_json #30636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1c6b786
Merge master
alimcmaster1 42a46d7
Fix test failures ignore FutureWarning
alimcmaster1 8331d06
Filter warning correctly
alimcmaster1 3ba4169
Fix imports
alimcmaster1 8302589
Merge remote-tracking branch 'remotes/upstream/master' into lucaiones…
alimcmaster1 5068771
Add warning annotation
alimcmaster1 8d65aa7
Remove unrequired annotation
alimcmaster1 8b7ac7d
Merge remote-tracking branch 'remotes/upstream/master' into lucaiones…
alimcmaster1 45c8237
Merge remote-tracking branch 'upstream/master' into lucaionescu-mcmali
alimcmaster1 cb74fe3
Update docs
alimcmaster1 d96d976
Merge remote-tracking branch 'upstream/master' into lucaionescu-mcmali
alimcmaster1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
from io import StringIO | ||
import json | ||
import os | ||
from warnings import catch_warnings, filterwarnings | ||
|
||
import numpy as np | ||
import pytest | ||
|
@@ -1606,3 +1607,13 @@ def test_emca_262_nan_inf_support(self): | |
["a", np.nan, "NaN", np.inf, "Infinity", -np.inf, "-Infinity"] | ||
) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
@pytest.mark.filterwarnings("ignore:.*msgpack:FutureWarning") | ||
def test_deprecate_numpy_argument_read_json(self): | ||
# https://github.com/pandas-dev/pandas/issues/28512 | ||
expected = DataFrame([1, 2, 3]) | ||
with tm.assert_produces_warning(None): | ||
alimcmaster1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
with catch_warnings(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are you catching warnings here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep unsure why this was in #28562. Now simplified |
||
filterwarnings("ignore", category=FutureWarning) | ||
result = read_json(expected.to_json(), numpy=True) | ||
tm.assert_frame_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.