CLN: replacing str.format with f-strings in several files. #29547 #30612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if x > 0 | ||
| else "color: {z}".format(z=z) | ||
| ) | ||
| g = lambda x, y, z: f"color: {z}" if x > 0 else f"color: {z}" |
There was a problem hiding this comment.
not related to the issue, maybe y can be removed here?
There was a problem hiding this comment.
Good idea! I'll look into taking care of it
There was a problem hiding this comment.
Thanks @jlamborn324 for the PR. generally lgtm. a few minor suggestions
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
jbrockmendel
reviewed
Jan 2, 2020
| @@ -711,7 +709,7 @@ def format_func(x): | |||
|
|
|||
| def test_to_string_with_formatters_unicode(self): | |||
| df = DataFrame({"c/\u03c3": [1, 2, 3]}) | |||
| result = df.to_string(formatters={"c/\u03c3": lambda x: "{x}".format(x=x)}) | |||
| result = df.to_string(formatters={"c/\u03c3": lambda x: f"{x}"}) | |||
There was a problem hiding this comment.
Good call. Thank you for your help!
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
|
Thanks for the clean up @jlamborn324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff