BUG: Series __setitem__ gives wrong result with bool indexer #30580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Series.__setitem__ gives wrong result with bool indexer and when length of new data matches the number of Trues and new data is neither a Series nor a numpy array
| or len(new) == 1 | ||
| ): | ||
| if mask[mask].shape[-1] == len(new): # GH 30567 | ||
| np.place(new_values, mask, new) |
There was a problem hiding this comment.
i had to look up what np.place was. is there a more common idiom we can use here?
There was a problem hiding this comment.
I can't find any close alternative from numpy. I think np.place in the right choice as it does exactly what we need here (it places all given values to the masked locations rather than assigning masked values to masked locations). Besides, it is designed to specifically work with book masks and that's what we are dealing with here.
jreback
added
Bug
Indexing
|
thanks @fujiaxiang very nice |
|
@fujiaxiang, thank you so much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series.setitem gives wrong result with bool indexer and when length of new data matches the number of Trues and new data is neither a Series nor a numpy array
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff