CLN: changed .format to f string in pandas/core/arrays/base.py

[Jcole429]

• ref Replace old string formatting syntax with f-strings #29547
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[WillAyd]

Sounds good thanks @Jcole429 !

[Jcole429]

@WillAyd , What is the best practice for maintaining my fork? Should I delete and make a new fork next time I want to contribute?

This action cannot be undone. This will permanently delete the Jcole429/pandas repository, wiki, issues, and comments, and remove all collaborator associations.

If I delete my fork, will I lose any evidence of collaboration from my profile?

Thank you

[WillAyd]

Set pandas as your upstream if you haven't already (noted in contributor guide) then just always pull updates from upstream/master to your local master. Then just branch locally off master to the branch you want and push that to your fork before making a PR

I wouldn't worry about keeping master on your fork in sync with pandas unless you have another reason to

[Jcole429]

Okay, I do have it set as my upstream. I'll do that, thank you!

Just for clarification, if I were to delete my fork, all evidence would be removed from my profile?

[WillAyd]

You can delete the branch on github after merge but keep your fork. You will push future branches to your fork

…

Sent from my iPhone

On Dec 17, 2019, at 10:42 AM, Justin Cole ***@***.***> wrote:  Okay, I do have it set as my upstream. I'll do that, thank you! Just for clarification, if I were to delete my fork, all evidence would be removed from my profile? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.