Skip to content

ENH: pass through schema keyword in to_parquet for pyarrow #30270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 18, 2019

Conversation

ieaves
Copy link
Contributor

@ieaves ieaves commented Dec 13, 2019

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add a test case for this feature?

@jorisvandenbossche

@WillAyd WillAyd added the IO Parquet parquet, feather label Dec 14, 2019
@ieaves
Copy link
Contributor Author

ieaves commented Dec 15, 2019

Added! I'm a first time contributor to pandas - let me know if that whatsnew entry was appropriate.

@jorisvandenbossche jorisvandenbossche changed the title Parquet schema ENH: pass through schema keyword in to_parquet for pyarrow Dec 15, 2019
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Dec 15, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also merge master

@ieaves
Copy link
Contributor Author

ieaves commented Dec 17, 2019

@jreback I merged master but it doesn't look like the build failures are a result of changes from this PR.

@TomAugspurger
Copy link
Contributor

Fixing that in another PR. You can ignore it for now.

@ieaves
Copy link
Contributor Author

ieaves commented Dec 17, 2019

Awesome, let me know if there's anything else we need in here.

@jorisvandenbossche jorisvandenbossche merged commit a0f334c into pandas-dev:master Dec 18, 2019
@jorisvandenbossche
Copy link
Member

Thanks a lot @ieaves !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No mechanism to enforce schema in to_parquet
5 participants