Skip to content

CLN: remove keep_null_freq in ops #30221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 12, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

This cleanup is viable now that integer-addition has been disallowed for dt64/td64.

@gfyoung gfyoung added Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Dec 12, 2019
with pytest.raises(TypeError, match=msg):
other - rng

# TODO: box and de-duplicate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@jreback jreback added this to the 1.0 milestone Dec 12, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. some comments by @gfyoung

@jbrockmendel
Copy link
Member Author

updated+green

@jreback jreback merged commit e883fb9 into pandas-dev:master Dec 12, 2019
@jreback
Copy link
Contributor

jreback commented Dec 12, 2019

thanks

@jbrockmendel jbrockmendel deleted the follow-intadd branch December 12, 2019 23:36
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants