f-string update for core.base.

[dplutcho]

• ref Replace old string formatting syntax with f-strings #29547
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[WillAyd]

Thanks for the PR. Looks good and I think CI failures are unrelated / have been fixed on master since this was created.

To be sure, can you locally on your feature-firstcontrib branch run:

git fetch upstream
git merge upstream/master
git push origin feature-firstcontrib

I think should get CI green for this. Flag me down at PyData if you have any questions

[dplutcho]

Done. All went fine. Do I need to do another pull request or is this all set. Darin Plutchok 206-909-3665

…

On Tue, Dec 3, 2019 at 8:48 PM William Ayd ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks for the PR. Looks good and I think CI failures are unrelated / have been fixed on master since this was created. To be sure, can you locally on your feature-firstcontrib branch run: git fetch upstream git merge upstream/master git push origin feature-firstcontrib I think should get CI green for this. Flag me down at PyData if you have any questions — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#30023?email_source=notifications&email_token=AAYK476CPUWZEZ2ZTSU26CTQW4ZDBA5CNFSM4JVAK22KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCN3YPHQ#pullrequestreview-326600606>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYK475B5N7KECJFTSGPOXTQW4ZDBANCNFSM4JVAK22A> .

[WillAyd]

Don't need a new PR; just keep pushing to this. Looks like CI is running so let's see

[simonjayhawkins]

@dplutcho lgtm pending green ci.

[jreback]

thanks @dplutcho