-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: Use conda for 3.8 build #29696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use conda for 3.8 build #29696
Conversation
nice |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good minor question that may not matter
@@ -30,11 +30,9 @@ matrix: | |||
- python: 3.5 | |||
|
|||
include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for changing this to trusty? Isn’t that an older image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The database services weren't starting up with bionic. Haven't looked into the differences at all.
thanks @TomAugspurger |
Closes #29001