CLN: assorted cleanups, mostly post-black fixups #28857

jbrockmendel · 2019-10-08T20:40:03Z

Mostly fixing extra " " introduced by black (will take a look at the issue tracker there to see if that can be fixed once and for all).

Also change except Foo as e: to except Foo as err and remove one except Exception in a docs file. Clarified a whatsnew note that @jorisvandenbossche asked for a while back.

pep8speaks · 2019-10-08T20:40:16Z

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-10 13:43:23 UTC

WillAyd

lgtm

WillAyd · 2019-10-08T20:53:04Z

pandas/tests/io/test_html.py

@@ -1233,8 +1233,8 @@ class ErrorThread(threading.Thread):
            def run(self):
                try:
                    super().run()
-                except Exception as e:
-                    self.err = e
+                except Exception as err:


I think you might have mentioned in the past but is there a flake8 rule for single character variable names? Worth turning on?

IIRC there is a rule that excludes lower-case "l", upper-case "I", and upper-case "O" as ambiguous. My complaint about the more general case is that these are hard to grep for.

jorisvandenbossche · 2019-10-08T21:13:25Z

doc/make.py

-                    # may not be able to read the rst because it has some
-                    # sphinx specific stuff
-                    title = "this page"
+                title = self._get_page_title(row[1])


Is there a reason you are changing this? Is the comment explaining it no longer true?

looking to see in the CI if something more specific is raised

jorisvandenbossche · 2019-10-08T21:14:27Z

doc/source/whatsnew/v1.0.0.rst

@@ -256,7 +256,7 @@ Timezones
 Numeric
 ^^^^^^^
 - Bug in :meth:`DataFrame.quantile` with zero-column :class:`DataFrame` incorrectly raising (:issue:`23925`)
- :class:`DataFrame` inequality comparisons with object-dtype and ``complex`` entries failing to raise ``TypeError`` like their :class:`Series` counterparts (:issue:`28079`)
+- :class:`DataFrame` flex inequality comparisons with object-dtype and ``complex`` entries failing to raise ``TypeError`` like their :class:`Series` counterparts (:issue:`28079`)


Suggestion: use "flexible comparison methods such as ..."

Can you do this one?

jbrockmendel · 2019-10-08T21:23:19Z

Opened an issue with black: psf/black#1051

jorisvandenbossche · 2019-10-09T15:47:12Z

doc/make.py

@@ -206,15 +207,15 @@ def _add_redirects(self):

                try:
                    title = self._get_page_title(row[1])
-                except Exception:
+                except docutils.io.InputError:


I don't think it is worth trying to pin down the exception, as explained in the comment below there are several cases where this may trigger an error. Why is that except Exception that bad?

Why is that except Exception that bad?

In this docs file it is pretty benign, and the motivation is largely "because it shows up whenever I grep for 'except Exception'".

jorisvandenbossche · 2019-10-09T20:38:06Z

doc/source/whatsnew/v1.0.0.rst

@@ -256,7 +256,7 @@ Timezones
 Numeric
 ^^^^^^^
 - Bug in :meth:`DataFrame.quantile` with zero-column :class:`DataFrame` incorrectly raising (:issue:`23925`)
- :class:`DataFrame` inequality comparisons with object-dtype and ``complex`` entries failing to raise ``TypeError`` like their :class:`Series` counterparts (:issue:`28079`)
+- :class:`DataFrame` flex inequality comparisons with object-dtype and ``complex`` entries failing to raise ``TypeError`` like their :class:`Series` counterparts (:issue:`28079`)


Can you do this one?

jorisvandenbossche · 2019-10-09T20:42:02Z

doc/make.py

@@ -206,15 +206,15 @@ def _add_redirects(self):

                try:
                    title = self._get_page_title(row[1])
-                except Exception:
+                except (docutils.utils.SystemMessage, FileNotFoundError):


I understand that, but in this case I think it is better to keep the Exception. We don't have proper tests for this, only one sphinx version and one docutils version on a clean doc build on Azure on one OS, but people can build the docs in many different ways in practice. I don't think we any guarantee that it will not give other errors there. And in this case it is also not a crucial part (like causing bugs in results) if we would swallow exceptions incorrectly.

@jbrockmendel maybe revert this

reverted+green

jorisvandenbossche · 2019-10-11T18:15:38Z

Thanks!

jbrockmendel added 4 commits October 8, 2019 13:24

clarify

0030ecf

CLN: e-->err

b8f81ab

CLN: extra spaces introduced by black

0fcb033

Merge branch 'master' of https://github.com/pandas-dev/pandas into cln2

56bd87e

blackify

a5d7d99

WillAyd approved these changes Oct 8, 2019

View reviewed changes

WillAyd added the Clean label Oct 8, 2019

fix namerror

572a034

jorisvandenbossche reviewed Oct 8, 2019

View reviewed changes

jbrockmendel added 2 commits October 8, 2019 16:36

specific error

e6f1758

catch better

0ccdce8

jorisvandenbossche reviewed Oct 9, 2019

View reviewed changes

jbrockmendel added 2 commits October 9, 2019 09:33

try again

60082a1

catch better

71eaf48

jorisvandenbossche requested changes Oct 9, 2019

View reviewed changes

jbrockmendel added 3 commits October 9, 2019 14:13

update whatsnew

4c38420

Merge branch 'master' of https://github.com/pandas-dev/pandas into cln2

dd2c299

Merge branch 'master' of https://github.com/pandas-dev/pandas into cln2

60b20f1

jreback added this to the 1.0 milestone Oct 11, 2019

jbrockmendel added 2 commits October 11, 2019 08:21

Merge branch 'master' of https://github.com/pandas-dev/pandas into cln2

423773e

revert

eb4b08a

jorisvandenbossche merged commit a31e160 into pandas-dev:master Oct 11, 2019

jbrockmendel deleted the cln2 branch October 11, 2019 18:35

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

CLN: assorted cleanups, mostly post-black fixups (pandas-dev#28857)

01084fe

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

CLN: assorted cleanups, mostly post-black fixups (pandas-dev#28857)

eb93d3a

bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020

CLN: assorted cleanups, mostly post-black fixups (pandas-dev#28857)

f9a5859

Uh oh!

CLN: assorted cleanups, mostly post-black fixups #28857

CLN: assorted cleanups, mostly post-black fixups #28857

Uh oh!

Conversation

jbrockmendel commented Oct 8, 2019

Uh oh!

pep8speaks commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2019-10-10 13:43:23 UTC

Uh oh!

WillAyd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbrockmendel commented Oct 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorisvandenbossche commented Oct 11, 2019

Uh oh!

Uh oh!

pep8speaks commented Oct 8, 2019 •

edited

Loading