Skip to content

CLN: dont catch Exception on reindex_multi #28853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 11, 2019
Merged

CLN: dont catch Exception on reindex_multi #28853

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d572f23
CLN: Exception
jbrockmendel Sep 17, 2019
7e3834f
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Sep 17, 2019
e482c32
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Sep 20, 2019
346b748
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Sep 23, 2019
47c94d7
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Sep 24, 2019
96df252
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Oct 1, 2019
faab752
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Oct 2, 2019
7812a2c
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4555,10 +4555,7 @@ def reindex(self, *args, **kwargs):

# check if we are a multi reindex
if self._needs_reindex_multi(axes, method, level):
try:
return self._reindex_multi(axes, copy, fill_value)
except Exception:
pass
return self._reindex_multi(axes, copy, fill_value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why i added this, but ok if everything passes


# perform the reindex on the axes
return self._reindex_axes(
Expand Down Expand Up @@ -9065,7 +9062,6 @@ def _where(

# try to not change dtype at first (if try_quick)
if try_quick:

new_other = com.values_from_object(self)
new_other = new_other.copy()
new_other[icond] = other
Expand Down