BUG: Series construction from MaskedArray fails for non-floating, non-object types #2880
+126
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Series constructor is throwing exceptions or ignoring the mask for non-floating, non-object MaskedArray input:
After fix:
The upcasting will only be done if necessary (i.e. if the mask has any
True
elements):This latter is a minor change to the previous behavior of the DataFrame constructor, which was upcasting correctly but was doing it even if the mask was all
False
: I've changed it to only upcast when necessary because this is more consistent with how masks are treated elsewhere.Also made some PEP8 line length fixes