CLN: Update cpython imports in Cython Code GH28382 #28398
Conversation
| from cpython.long cimport PyLong_Check | ||
| from cpython.object cimport PyCallable_Check | ||
| from cpython.tuple cimport PyTuple_Check | ||
| from cpython.unicode cimport PyUnicode_Check, PyUnicode_AsEncodedString |
There was a problem hiding this comment.
doesnt need to be for this PR, but most/all of the PyFoo_Check calls can be replaced with their pure-python equivalents; cython will now automatically make the optimization
There was a problem hiding this comment.
So basically replace this with isinstance checks right? I think OK as a separate PR @amunch if that's something you'd also like to tackle
There was a problem hiding this comment.
Sounds good, I will replace these checks in a separate pull request.
| from cpython.long cimport PyLong_Check | ||
| from cpython.object cimport PyCallable_Check | ||
| from cpython.tuple cimport PyTuple_Check | ||
| from cpython.unicode cimport PyUnicode_Check, PyUnicode_AsEncodedString |
There was a problem hiding this comment.
So basically replace this with isinstance checks right? I think OK as a separate PR @amunch if that's something you'd also like to tackle
|
@WillAyd Looks like merging master resolved the CI issues! |
|
LGTM. Should we add a code check for this? |
Not against it if someone wants to take that up, but don't think needs to be done as part of this PR |
|
Thanks @amunch - great first PR |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffApologies if anything is not ideal, as this is my first pull request here. Any suggestions or comments are much appreciated!