Skip to content

DOC: Fix typo in min_rows / max_rows option example #28281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

tobycheese
Copy link
Contributor

  • Fix typo in example
  • Regenerated output also seems to fix a bad output in the next line (out 32 in current online documentation) where df is truncated, when it shouldn't by according to the code

@tobycheese
Copy link
Contributor Author

tobycheese commented Sep 4, 2019

Also, when looking at the current online documentation, more things seem to be off. The example about display.expand_frame_reprdoes not show any difference between the two settings. Rebuilding the page seems to fix this, my local version looks good.

@tobycheese tobycheese changed the title DOCS: Fix typo in min_rows / max_rows option example DOC: Fix typo in min_rows / max_rows option example Sep 4, 2019
@jbrockmendel
Copy link
Member

@datapythonista this looks fine to me, but I don't know this area that well.

@WillAyd WillAyd added the Docs label Sep 4, 2019
@WillAyd WillAyd added this to the 1.0 milestone Sep 4, 2019
@WillAyd WillAyd merged commit 4252ab7 into pandas-dev:master Sep 4, 2019
@WillAyd
Copy link
Member

WillAyd commented Sep 4, 2019

Great thanks @tobycheese

@tobycheese tobycheese deleted the fix_min_row_doc branch September 5, 2019 07:49
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants