Skip to content

DEV: remove seed isort config #28272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

TomAugspurger
Copy link
Contributor

This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes #28236

This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
@WillAyd
Copy link
Member

WillAyd commented Sep 3, 2019

OK by me but cc @sbalk and @basnijholt for insight

@basnijholt
Copy link
Contributor

I added it because it solved a particular problem. I didn’t anticipate that it would cause any problems. I’m also fine with deleting it.

@jreback jreback added the Admin Administrative tasks related to the pandas project label Sep 4, 2019
@jreback jreback added this to the 1.0 milestone Sep 4, 2019
@jreback jreback added CI Continuous Integration and removed Admin Administrative tasks related to the pandas project labels Sep 4, 2019
@jreback jreback merged commit 243c1bc into pandas-dev:master Sep 4, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
This was causing issues for me locally. Anyone else?

It took a while to run, and didn't seem to give the same
output as others (depends on something peculiar to my environment)
which doesn't seem to be great for a pre-commit hook.

Closes pandas-dev#28236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seed isort known_third_party pre-commit hook
4 participants