-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
PERF: asv for import #28239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
PERF: asv for import #28239
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ec4d89e
cleanup unnecessary comma
jbrockmendel 47b6de7
remove trailing comma
jbrockmendel ed992bc
benchmark for import
jbrockmendel 015e270
double quotes
jbrockmendel 72aeb48
missing whitespce
jbrockmendel 076ab3e
Merge branch 'master' of https://github.com/pandas-dev/pandas into im…
jbrockmendel b06cb1b
use subprocess.run
jbrockmendel 0629ac5
Merge branch 'master' of https://github.com/pandas-dev/pandas into im…
jbrockmendel 0a6e2b8
Merge branch 'master' of https://github.com/pandas-dev/pandas into im…
jbrockmendel a5d9eb2
comment
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
""" | ||
Benchmarks for pandas at the package-level. | ||
""" | ||
import subprocess | ||
import sys | ||
|
||
from pandas.compat import PY37 | ||
|
||
|
||
class TimeImport: | ||
def time_import(self): | ||
if PY37: | ||
# on py37+ we the "-X importtime" usage gives us a more precise | ||
# measurement of the import time we actually care about, | ||
# without the subprocess or interpreter overhead | ||
cmd = [sys.executable, "-X", "importtime", "-c", "import pandas as pd"] | ||
p = subprocess.run(cmd, stderr=subprocess.PIPE) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a comment for this as 3.7 actually does the timing, where for < 3.7 asv is doing the timing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comment added + green |
||
|
||
line = p.stderr.splitlines()[-1] | ||
field = line.split(b"|")[-2].strip() | ||
total = int(field) # microseconds | ||
return total | ||
|
||
cmd = [sys.executable, "-c", "import pandas as pd"] | ||
subprocess.run(cmd, stderr=subprocess.PIPE) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.