Skip to content

BUG: Fix fields functions with readonly data, vaex#357 #27529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2019
Merged

BUG: Fix fields functions with readonly data, vaex#357 #27529

merged 6 commits into from
Jul 24, 2019

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

pep8speaks commented Jul 22, 2019 •
edited
Loading

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-23 23:47:57 UTC

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype labels Jul 23, 2019
@jreback
Copy link
Contributor

jreback commented Jul 23, 2019

looks fine, can you add a note. ok with backporting if you want.

@jbrockmendel
Copy link
Member Author

note added

@jreback jreback added this to the 1.0 milestone Jul 24, 2019
@jreback jreback merged commit 5d10aa4 into pandas-dev:master Jul 24, 2019
@jreback
Copy link
Contributor

jreback commented Jul 24, 2019

thxs

@jbrockmendel jbrockmendel deleted the deps2 branch July 24, 2019 13:22
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
@jbrockmendel @quintusdias
BUG: Fix fields functions with readonly data, vaex#357 (pandas-dev#27529
7b3b9ab 
)

* Fix fields functions with readonly data, vaex#357

* lint fixup

* add whatsnew

* isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @pep8speaks @jreback