CLN: assorted cleanups #27301
Merged
CLN: assorted cleanups #27301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jul 9, 2019
pandas/core/internals/managers.py
Outdated
| @@ -584,6 +584,7 @@ def convert(self, **kwargs): | |||
| return self.apply("convert", **kwargs) | |||
|
|
|||
| def replace(self, **kwargs): | |||
| assert "value" in kwargs and np.ndim(kwargs["value"]) == 0 | |||
There was a problem hiding this comment.
Does adding this to the signature explicitly not work?
There was a problem hiding this comment.
I think it does, but the pattern for the other self.aply usages here is just to have kwargs. I'm OK either way
There was a problem hiding this comment.
Yea I think signature would be better if required
| @@ -411,7 +411,7 @@ def check_single_invert_op(self, lhs, cmp1, rhs): | |||
| ) | |||
|
|
|||
| def check_compound_invert_op(self, lhs, cmp1, rhs): | |||
| skip_these = "in", "not in" | |||
| skip_these = ["in", "not in"] | |||
There was a problem hiding this comment.
Maybe make a tuple for consistency with old code?
There was a problem hiding this comment.
Just used for an inclusion check; either way works.
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken off from other branches