Skip to content

REF: ops.missing #27257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2019
Merged

REF: ops.missing #27257

merged 3 commits into from
Jul 6, 2019

Conversation

jbrockmendel
Copy link
Member

  • Move arithmetic-centric functions from core.missing to core.ops.missing.
  • module-level docstring giving the motivation for these functions
  • tiny optimization:
if op in [operator.floordiv, operator.truediv, getattr(operator, "div", None)]:
    result = mask_zero_div_zero(left, right, result)

becomes

if op is operator.floordiv:
    result = mask_zero_div_zero(left, right, result)

because in py3 numpy behaves the way we want for truediv.

jbrockmendel
jbrockmendel commented Jul 6, 2019
View reviewed changes
pandas/tests/indexing/test_coercion.py
@@ -1063,8 +1063,7 @@ def test_replace_series_datetime_tz(self):

# TODO(jreback) commented out to only have a single xfail printed
@pytest.mark.xfail(
reason="different tz, " "currently mask_missing raises SystemError",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of these appear to have been introduced by black

@gfyoung gfyoung added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Refactor Internal refactoring of code labels Jul 6, 2019
@jreback jreback added this to the 0.25.0 milestone Jul 6, 2019
@jreback jreback merged commit 8794516 into pandas-dev:master Jul 6, 2019
@jreback
Copy link
Contributor

jreback commented Jul 6, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the mops branch July 6, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Refactor Internal refactoring of code
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @gfyoung