CLN: remove never-used branch from Series ops #27236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 5, 2019
pandas/core/ops.py
Outdated
| @@ -1713,10 +1713,6 @@ def na_op(x, y): | |||
| result = expressions.evaluate(op, str_rep, x, y, **eval_kwargs) | |||
| except TypeError: | |||
| result = masked_arith_op(x, y, op) | |||
| except Exception: # TODO: more specific? | |||
There was a problem hiding this comment.
this seems to be the only usage, let's remove arrmap_object as well
There was a problem hiding this comment.
ahh I c, this is parametrized, ok then.
There was a problem hiding this comment.
actually do we use arrmap_* anywhere?
jreback
added
Clean
Internals
jreback
approved these changes
Jul 5, 2019
jreback
requested changes
Jul 5, 2019
There was a problem hiding this comment.
-revising again; looks like we can completely remove arrmap_*-
nope looks like 1 usage (after you remove this one)
(pandas) bash-3.2$ grep -r arrmap_ pandas --include '*.py'
pandas/core/algorithms.py: return algos.arrmap_float64(q, _get_score)
pandas/core/ops.py: return libalgos.arrmap_object(x, lambda val: op(val, y))
pandas/tests/test_algos.py: result = libalgos.arrmap_object(values, lambda x: x in ["foo", "bar"])
(pandas) bash-3.2$ grep -r arrmap_ pandas --include '*.pyx'
pandas/_libs/algos.pyx:arrmap_float64 = arrmap["float64_t"]
pandas/_libs/algos.pyx:arrmap_float32 = arrmap["float32_t"]
pandas/_libs/algos.pyx:arrmap_object = arrmap["object"]
pandas/_libs/algos.pyx:arrmap_int64 = arrmap["int64_t"]
pandas/_libs/algos.pyx:arrmap_int32 = arrmap["int32_t"]
pandas/_libs/algos.pyx:arrmap_uint64 = arrmap["uint64_t"]
pandas/_libs/algos.pyx:arrmap_bool = arrmap["uint8_t"]
|
So what's the conclusion re arrmap_*? |
|
pandas/core/algorithms.py I think you can just do |
|
I'll open an issue to look into this more carefully. |
jreback
approved these changes
Jul 5, 2019
|
cool, ping on green. |
|
ping |
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost gets to a point where Series and DataFrame ops can share the na_op definition.
AFAICT this is the only non-test usage of libalgos.arrmap_object.