Skip to content

TST/REF: parametrize arithmetic tests, simplify parts of core.ops #26799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 25, 2019

Conversation

jbrockmendel
Copy link
Member

Parametrization is straightforward.
Fixing xfailed test in test_properties is straightforward

In core.ops: ATM we have a nested closure that wraps all of na_op in a try/except, but there is really only one line we want to catch. This simplifies the closure and catches only the relevant line.

@pep8speaks
Copy link

pep8speaks commented Jun 12, 2019

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-25 14:10:41 UTC

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26799 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26799      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50771       -3     
==========================================
- Hits        46712    46705       -7     
- Misses       4062     4066       +4
Flag Coverage Δ
#multiple 90.63% <100%> (-0.01%) ⬇️
#single 41.85% <50%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/ops.py 94.66% <100%> (-0.03%) ⬇️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0919f2...c75bf32. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26799 into master will decrease coverage by 50.52%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26799       +/-   ##
===========================================
- Coverage   91.73%   41.21%   -50.53%     
===========================================
  Files         178      178               
  Lines       50774    50771        -3     
===========================================
- Hits        46579    20924    -25655     
- Misses       4195    29847    +25652
Flag Coverage Δ
#multiple ?
#single 41.21% <50%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/ops.py 52.23% <50%> (-42.45%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/plotting/_matplotlib/__init__.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/sparse/scipy_sparse.py 10.14% <0%> (-89.86%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ad9da...da7532d. Read the comment docs.

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Jun 13, 2019
@@ -1077,7 +1077,7 @@ def fill_binop(left, right, fill_value):
return left, right


def mask_cmp_op(x, y, op, allowed_types):
def mask_cmp_op(x, y, op):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add types where possible (not asking for everything of course, but if convenient / obvious)

@jbrockmendel
Copy link
Member Author

It looks like hypothesis is having trouble here, but only in some builds

@jbrockmendel
Copy link
Member Author

Punter on hypothesis breakage

@jreback jreback added this to the 0.25.0 milestone Jun 25, 2019
@jreback
Copy link
Contributor

jreback commented Jun 25, 2019

lgtm. can you merge master again to make sure ok (as just merged the other 0dim change).

@jreback jreback merged commit f558763 into pandas-dev:master Jun 25, 2019
@jreback
Copy link
Contributor

jreback commented Jun 25, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the arithtests branch June 25, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants