-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
TST/REF: parametrize arithmetic tests, simplify parts of core.ops #26799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-06-25 14:10:41 UTC |
Codecov Report
@@ Coverage Diff @@
## master #26799 +/- ##
==========================================
- Coverage 91.99% 91.99% -0.01%
==========================================
Files 180 180
Lines 50774 50771 -3
==========================================
- Hits 46712 46705 -7
- Misses 4062 4066 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26799 +/- ##
===========================================
- Coverage 91.73% 41.21% -50.53%
===========================================
Files 178 178
Lines 50774 50771 -3
===========================================
- Hits 46579 20924 -25655
- Misses 4195 29847 +25652
Continue to review full report at Codecov.
|
@@ -1077,7 +1077,7 @@ def fill_binop(left, right, fill_value): | |||
return left, right | |||
|
|||
|
|||
def mask_cmp_op(x, y, op, allowed_types): | |||
def mask_cmp_op(x, y, op): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add types where possible (not asking for everything of course, but if convenient / obvious)
It looks like hypothesis is having trouble here, but only in some builds |
Punter on hypothesis breakage |
lgtm. can you merge master again to make sure ok (as just merged the other 0dim change). |
thanks @jbrockmendel |
Parametrization is straightforward.
Fixing xfailed test in test_properties is straightforward
In core.ops: ATM we have a nested closure that wraps all of na_op in a try/except, but there is really only one line we want to catch. This simplifies the closure and catches only the relevant line.