Skip to content

Test conda 4.7.1 #26595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 26, 2019
Merged

Test conda 4.7.1 #26595

merged 17 commits into from
Jun 26, 2019

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented May 31, 2019

Testing conda 4.7.x

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #26595 into master will decrease coverage by 50.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26595       +/-   ##
===========================================
- Coverage   91.84%   41.69%   -50.16%     
===========================================
  Files         174      174               
  Lines       50644    50644               
===========================================
- Hits        46516    21116    -25400     
- Misses       4128    29528    +25400
Flag Coverage Δ
#multiple ?
#single 41.69% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.14% <0%> (-89.86%) ⬇️
pandas/io/s3.py 0% <0%> (-89.48%) ⬇️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f31865...418351d. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #26595 into master will increase coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26595      +/-   ##
==========================================
+ Coverage   90.64%      92%   +1.35%     
==========================================
  Files         180      180              
  Lines       50754    50754              
==========================================
+ Hits        46005    46695     +690     
+ Misses       4749     4059     -690
Flag Coverage Δ
#multiple 90.64% <100%> (ø) ⬆️
#single 41.85% <0%> (?)
Impacted Files Coverage Δ
pandas/compat/_optional.py 100% <ø> (ø) ⬆️
pandas/io/html.py 94.29% <100%> (ø) ⬆️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️
pandas/core/arrays/categorical.py 95.92% <0%> (+0.12%) ⬆️
pandas/core/indexes/datetimes.py 96.37% <0%> (+0.16%) ⬆️
pandas/io/formats/printing.py 86.72% <0%> (+0.94%) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <0%> (+2.89%) ⬆️
pandas/core/computation/expr.py 97.8% <0%> (+3.02%) ⬆️
pandas/core/computation/common.py 89.47% <0%> (+5.26%) ⬆️
pandas/io/pytables.py 90.3% <0%> (+25.43%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9182df...869dab6. Read the comment docs.

@gfyoung gfyoung added Build Library building on various platforms Testing pandas testing functions or related to the test suite labels May 31, 2019
@TomAugspurger
Copy link
Contributor Author

@simonjayhawkins simonjayhawkins removed the Testing pandas testing functions or related to the test suite label May 31, 2019
@TomAugspurger
Copy link
Contributor Author

To summarize, conda is removing the free channel by default, so some of our older packages won't be installed. Here are the packages requiring bumps:

library old pin minimum conda release date
pytz 2015.4 2017.2 March 2017
beautifulsoup4 4.4.1 4.6.0 May 2017
xlwt 1.0.0 1.2.0 January 2017
python-dateutil 2.5.0 2.6.1 July 2017
xlsxwriter 0.7.7 0.9.8 July 2017
openpyxl 2.4.0 2.4.8 May 2017

Our options

  1. Bump our minimum supported versions to those
  2. Move to pip for the ones that can't come from Conda anymore
  3. Add back the free channel

I think 1 or 2 is fine. I have a slight preference for 1, but either works.

@WillAyd
Copy link
Member

WillAyd commented Jun 11, 2019 via email

@jreback
Copy link
Contributor

jreback commented Jun 11, 2019

I agree, ok with bumping

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Jun 13, 2019
@TomAugspurger
Copy link
Contributor Author

Hopefully this next one passes, and we'll be ready.

Reminder: that we don't want to merge this. I'll make another PR for any additional prep changes (right now, just bumping the min version for pymysql)

@TomAugspurger
Copy link
Contributor Author

Bumping gcsfs to 0.2.2; That's needed for compatibility with recent versions of dask.

@TomAugspurger TomAugspurger changed the title [WIP]: Test conda 4.7.1 Test conda 4.7.1 Jun 25, 2019
@TomAugspurger
Copy link
Contributor Author

FYI I've reverted the Conda-canary install of 4.7.x

This has a few more changes (version bumps) we should merge before 4.7.3 is released, which is happening soonish.

@TomAugspurger
Copy link
Contributor Author

Conda 4.7 is out now, so I think this is affecting PRs.

Merging later tonight if there are no objections.

@TomAugspurger TomAugspurger merged commit 6119d02 into pandas-dev:master Jun 26, 2019
@TomAugspurger TomAugspurger deleted the conda-4.7.1 branch June 26, 2019 11:21
@@ -9,7 +9,8 @@
"bs4": "4.6.0",
"bottleneck": "1.2.1",
"fastparquet": "0.2.1",
"gcsfs": "0.1.0",
"gcsfs": "0.2.2",
"lxml.etree": "3.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob should add pymysql here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants