-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Test conda 4.7.1 #26595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test conda 4.7.1 #26595
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26595 +/- ##
===========================================
- Coverage 91.84% 41.69% -50.16%
===========================================
Files 174 174
Lines 50644 50644
===========================================
- Hits 46516 21116 -25400
- Misses 4128 29528 +25400
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26595 +/- ##
==========================================
+ Coverage 90.64% 92% +1.35%
==========================================
Files 180 180
Lines 50754 50754
==========================================
+ Hits 46005 46695 +690
+ Misses 4749 4059 -690
Continue to review full report at Codecov.
|
The remaining failures are due to the |
To summarize, conda is removing the
Our options
I think 1 or 2 is fine. I have a slight preference for 1, but either works. |
Releases are two years old at this point so I think option 1 is fine as well
…Sent from my iPhone
On Jun 11, 2019, at 1:03 PM, Tom Augspurger ***@***.***> wrote:
To summarize, conda is removing the free channel by default, so some of our older packages won't be installed. Here are the packages requiring bumps:
library old pin minimum conda release date
pytz 2015.4 2017.2 March 2017
beautifulsoup4 4.4.1 4.6.0 May 2017
xlwt 1.0.0 1.2.0 January 2017
python-dateutil 2.5.0 2.6.1 July 2017
xlsxwriter 0.7.7 0.9.8 July 2017
openpyxl 2.4.0 2.4.8 May 2017
Our options
Bump our minimum supported versions to those
Move to pip for the ones that can't come from Conda anymore
Add back the free channel
I think 1 or 2 is fine. I have a slight preference for 1, but either works.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I agree, ok with bumping |
Hopefully this next one passes, and we'll be ready. Reminder: that we don't want to merge this. I'll make another PR for any additional prep changes (right now, just bumping the min version for pymysql) |
f77444e
to
deea532
Compare
Bumping gcsfs to 0.2.2; That's needed for compatibility with recent versions of dask. |
FYI I've reverted the Conda-canary install of 4.7.x This has a few more changes (version bumps) we should merge before 4.7.3 is released, which is happening soonish. |
Conda 4.7 is out now, so I think this is affecting PRs. Merging later tonight if there are no objections. |
@@ -9,7 +9,8 @@ | |||
"bs4": "4.6.0", | |||
"bottleneck": "1.2.1", | |||
"fastparquet": "0.2.1", | |||
"gcsfs": "0.1.0", | |||
"gcsfs": "0.2.2", | |||
"lxml.etree": "3.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prob should add pymysql here as well
Testing conda 4.7.x