-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Add more specific error message when user passes incorrect matrix format to from_coo #26584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ed8baec
Include more specific error messaging for non coo matrix and introduc…
fhoang7 811647d
Log changes to what's new
fhoang7 282bc9f
Remove redundant test
fhoang7 ceab97d
Fix pep8
fhoang7 69ea6f2
Change test to expect TypeError
fhoang7 21ecdab
Update what's new
fhoang7 d8405fc
Update docstring to reflect what will be returned in an error state
fhoang7 18a62b9
Merge remote-tracking branch 'upstream/master' into first-feature
fhoang7 b2b9239
- Update what's new
fhoang7 fb6e0d9
- Clean up what's new formatting
fhoang7 8739f29
Add message assertion to test and change test name to be more verbose…
fhoang7 633b1ff
Proper formatting in what's new + proper commenting for test
fhoang7 206faff
Fix test name for consistency and assert on literal message
fhoang7 cc44ac0
Merge remote-tracking branch 'upstream/master' into first-feature
fhoang7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.