Skip to content

CLN: Cleanup code in parsers.pyx #26386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019
Merged

CLN: Cleanup code in parsers.pyx #26386

merged 1 commit into from
May 14, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented May 14, 2019

No description provided.

@gfyoung gfyoung added IO CSV read_csv, to_csv Internals Related to non-user accessible pandas implementation Clean labels May 14, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone May 14, 2019
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #26386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26386   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files         174      174           
  Lines       50704    50704           
=======================================
  Hits        46488    46488           
  Misses       4216     4216
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 304d8d4...7f81c39. Read the comment docs.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7ba2ec8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26386   +/-   ##
=========================================
  Coverage          ?   91.68%           
=========================================
  Files             ?      174           
  Lines             ?    50704           
  Branches          ?        0           
=========================================
  Hits              ?    46488           
  Misses            ?     4216           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.18% <ø> (?)
#single 41.33% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba2ec8...4196a49. Read the comment docs.

@gfyoung gfyoung force-pushed the parsers-pyx-cleanup branch from 7f81c39 to 4196a49 Compare May 14, 2019 16:21
@jreback jreback merged commit ef7dc2f into master May 14, 2019
@jreback
Copy link
Contributor

jreback commented May 14, 2019

thanks @gfyoung failure was unrelated

@gfyoung gfyoung deleted the parsers-pyx-cleanup branch May 14, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants