Skip to content

Improve where docstring #26018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Improve where docstring #26018

merged 1 commit into from
Apr 7, 2019

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Apr 7, 2019

A couple small fixes to the where docstring, also making an example a bit more clear.

@WillAyd
Copy link
Member

WillAyd commented Apr 7, 2019

Changes look good I think failures are from a flaky test so restarted

@WillAyd WillAyd added the Docs label Apr 7, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Apr 7, 2019
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #26018 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26018      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52551              
==========================================
- Hits        48256    48252       -4     
- Misses       4295     4299       +4
Flag Coverage Δ
#multiple 90.38% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.54% <ø> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...fd29fc7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #26018 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26018      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52551              
==========================================
- Hits        48256    48252       -4     
- Misses       4295     4299       +4
Flag Coverage Δ
#multiple 90.38% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.54% <ø> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...fd29fc7. Read the comment docs.

@WillAyd WillAyd merged commit 6c613c8 into pandas-dev:master Apr 7, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 7, 2019

Thanks @dsaxton

@dsaxton dsaxton deleted the doc-fix branch April 7, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants