Skip to content

TST: Add regression test for #23986 #25931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2019
Merged

TST: Add regression test for #23986 #25931

merged 2 commits into from
Mar 31, 2019

Conversation

alexcwatt
Copy link
Contributor

@alexcwatt alexcwatt changed the title Add regression test for #23986 TST: Add regression test for #23986 Mar 30, 2019
@alexcwatt alexcwatt force-pushed the regresion-test-23986 branch from 1d58d2a to 1d25bbe Compare March 30, 2019 22:57
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #25931 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25931      +/-   ##
==========================================
- Coverage   91.81%    91.8%   -0.01%     
==========================================
  Files         175      175              
  Lines       52578    52578              
==========================================
- Hits        48273    48269       -4     
- Misses       4305     4309       +4
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ba498...1d25bbe. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 30, 2019 •
edited
Loading

Codecov Report

Merging #25931 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25931      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52578    52580       +2     
==========================================
+ Hits        48273    48274       +1     
- Misses       4305     4306       +1
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/groupby/grouper.py 98.16% <0%> (-0.36%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/core/generic.py 93.54% <0%> (ø) ⬆️
pandas/core/indexes/base.py 96.79% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ba498...ba004c9. Read the comment docs.

WillAyd
WillAyd requested changes Mar 30, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but otherwise lgtm. @mroeschke

pandas/tests/indexes/datetimes/test_construction.py Outdated
@@ -535,6 +535,12 @@ def test_constructor_dtype(self):
result = DatetimeIndex(idx, dtype='datetime64[ns, US/Eastern]')
tm.assert_index_equal(idx, result)

@pytest.mark.parametrize('dtype', [object, np.int32, np.int64])
def test_constructor_invalid_dtype(self, dtype):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just append _raises to the end of this? Convention we have for tests

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Mar 30, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 30, 2019
@mroeschke mroeschke merged commit b727c6b into pandas-dev:master Mar 31, 2019
@mroeschke
Copy link
Member

Thanks @alexcwatt!

If you're up for it, we have more issues that could be closed by adding regression tests. https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+label%3A%22Needs+Tests%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

DatetimeIndex doesn't validate dtype argument
3 participants
@alexcwatt @mroeschke @WillAyd