-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Interval dtype fix #25338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Interval dtype fix #25338
Changes from 14 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
6185319
Merge pull request #1 from pandas-dev/master
zangell44 1c4decd
interval constructor logic modified and error handling for is_dtype u…
zangell44 d52c631
formatting updates for error msg
zangell44 c1b7d7f
committing latest upstream master changes to branch
zangell44 953823e
subtype check logic implemented for Interval dtype
zangell44 8edbbd8
tests added to ensure pd.api.types.IntervalDtype.is_dtype(IntervalA)…
zangell44 8e54308
tests added to ensure * pd.api.types.IntervalDtype(IntervalA) throws …
zangell44 eec5013
test added to ensure pd.api.types.IntervalDtype.construct_from_string…
zangell44 708a740
PEP8 style issues resolved
zangell44 9ae2afc
more PEP8 style issues resolved
zangell44 0837c85
subtype checking consolidated into for loop
zangell44 c0818b6
logic change to include issubtype must result in True
zangell44 dedba89
logic change for checking datetime and timedelta dtypes
zangell44 6914a7b
extra blank line removed
zangell44 e9c18e9
Merge remote-tracking branch 'upstream/master' into interval-dtype-fix
zangell44 c53d69c
reset to original logic on working branch, only tests written remain …
zangell44 f2d2390
logic for string constructor and error message content updated
zangell44 08ea833
construction error for IntervalA parameter moved to proper test
zangell44 1a5fc1b
IntervalDtype construct_from_string tests updated to separate a bad d…
zangell44 f2a3bdb
TypeError added to is_dtype exceptions, reflecting changes in the con…
zangell44 0011a80
formatting fixes and test update
zangell44 aa581fa
formatting update
zangell44 54bcf76
construct from string formatting fixes
zangell44 36f8571
interval[foo] construct from string error moved to proper test category
zangell44 6e6fe23
IntervalA construct from string error moved to proper test category
zangell44 5547b5f
IntervalDtype construct from string test error message handling updat…
zangell44 aedc7cc
re-ordering of logic in construct from string method for cleaner code
zangell44 2deba07
message string altered to work with regex matching
zangell44 c107ccd
IntervalA test re-added to construct from string testing
zangell44 989942e
error message formatting fix for PEP8
zangell44 d28a0fd
test added for comparing series with strings containing Interval keyword
zangell44 e72bfb9
regression fix documented in whats new for v0.24.2
zangell44 dfe6e99
typo fix in construct_from_string error message
zangell44 f08915f
typo fix in construct_from_string error message
zangell44 f1fabdf
whatsnew note adjusted for clarity and style
zangell44 1ed7f8c
formatting update for test_compare_series_interval_keyword
zangell44 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.