-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fix type coercion in read_json orient='table' (#21345) #25219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e527545
BUG: Fix type coercion in read_json orient='table' (#21345)
45faaba
Fix and add tests
7a084ad
Add GH issue number as a comment to the new test
f39bbf9
Change docstring
4f5c3b3
Raise error if dtype is not None and orient='table'
bc2c1dd
Test raised error if not None dtype and orient='table'
a78cc2e
Move to read_json default setting dtype=False for 'table'
933eb51
Fix docstring formatting for rendering
67a8571
Add whatsnew note
b0b2410
Fix default dtype depending on orient
55adbc0
Explain better in whatsnew note
cc4c4e3
Merge branch 'master' into fix-21345
99074e3
Address requested changes
d96b304
Make whatsnew note more clear
bf98bf8
Use pytest.raises
6325365
Move default dtype setting to read_json
c0d348c
Set assignment in Parser
900a3f0
Allow orient=table and dtype=False
4ecf5c6
Fix test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.