Skip to content

str.replace('.','') should replace every character? (fix) #24809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

str.replace('.','') should replace every character? (fix) #24809

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c984582
string replace pattern size fix
alarangeiras Jan 16, 2019
67b0870
adding test case to replace pattern problem
alarangeiras Jan 16, 2019
340ae89
- adding comments and refactoring
alarangeiras Jan 16, 2019
5a4e131
removing len check from replace pattern
alarangeiras Jan 17, 2019
cf8dc79
- refactoring test case variable name
alarangeiras Jan 17, 2019
924ecc8
removing whitespace in the end of the line
alarangeiras Jan 17, 2019
97bf73a
- changing the position of the API breaking note
alarangeiras Jan 17, 2019
da16172
removing whitespace from the documentation
alarangeiras Jan 17, 2019
93a0715
- making the changes requested by the project members
alarangeiras Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def str_replace(arr, pat, repl, n=-1, case=None, flags=0, regex=True):
# add case flag, if provided
if case is False:
flags |= re.IGNORECASE
if is_compiled_re or len(pat) > 1 or flags or callable(repl):
if is_compiled_re or len(pat) > 0 or flags or callable(repl):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need the len(pat) condition? Can it just be pat instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be just pat, the only issue is case pat is empty.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn’t that be False in either case? If so shouldn’t need the len expression

n = n if n >= 0 else 0
compiled = re.compile(pat, flags=flags)
f = lambda x: compiled.sub(repl=repl, string=x, count=n)
Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/test_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,13 @@ def test_replace(self):
values = klass(data)
pytest.raises(TypeError, values.str.replace, 'a', repl)

def test_replace_single_pattern(self):
values = Series(['abc','123'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment for the issue (# GH 24804)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes


result = values.str.replace('.', 'foo')
exp = Series(['foofoofoo', 'foofoofoo'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name this expected?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, should I make another PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No just add as a commit and push on the same branch.

Looks like CI failed too -haven’t checked but make sure tests pass locally before pushing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i've seem that.
Actually, i know what is the problem.
The problem is the test test_pipe_failures. It was built to test a char replacement: pipe to white space.
But, pipe is a regex code too.
When i fixed the replace behavior, this test was broken.
My proposal is change this test to pass the regex=False parameter. Like below:

    def test_pipe_failures(self):
        # #2119
        s = Series(['A|B|C'])

        result = s.str.split('|')
        exp = Series([['A', 'B', 'C']])

        tm.assert_series_equal(result, exp)

        result = s.str.replace('|', ' ', regex=False)
        exp = Series(['A B C'])

        tm.assert_series_equal(result, exp)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to think about that?

tm.assert_series_equal(result, exp)

def test_replace_callable(self):
# GH 15055
values = Series(['fooBAD__barBAD', NA])
Expand Down