-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
remove unused kwarg #24695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused kwarg #24695
Conversation
elif is_object_dtype(dtype): | ||
klass = ObjectBlock | ||
elif is_extension_array_dtype(dtype): | ||
klass = ExtensionBlock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone more familiar with this than me may want to double-check if these 7 lines are still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes @TomAugspurger recently modified this for Sparse
Codecov Report
@@ Coverage Diff @@
## master #24695 +/- ##
==========================================
+ Coverage 92.38% 92.38% +<.01%
==========================================
Files 166 166
Lines 52310 52310
==========================================
+ Hits 48326 48327 +1
+ Misses 3984 3983 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24695 +/- ##
==========================================
+ Coverage 92.38% 92.38% +<.01%
==========================================
Files 166 166
Lines 52310 52310
==========================================
+ Hits 48326 48327 +1
+ Misses 3984 3983 -1
Continue to review full report at Codecov.
|
thanks! |
AFAICT
klass
is never passed toastype
, so the kwarg can be removed.git diff upstream/master -u -- "*.py" | flake8 --diff