REF: move templated index.pyx code to non-template #24669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 8, 2019
pandas/_libs/index.pyx
Outdated
| @@ -681,5 +687,10 @@ cdef class BaseMultiIndexCodesEngine: | |||
| return False | |||
|
|
|||
|
|
|||
| cdef class ObjectEngine(IndexEngine): | |||
There was a problem hiding this comment.
I would move this much higher up, is it the intention NOT to inherit from this?
There was a problem hiding this comment.
can you add a class description (ideally for other engines too, but ok for here now)
There was a problem hiding this comment.
Yah inheritance in this file is weird; DatetimeEngine etc all subclass Int64Engine, which isn't defined until lower in the file once the "include ..." is done. I'll move this up and add a description, sure.
jreback
approved these changes
Jan 8, 2019
|
yeah this is ok. |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following cleanup of libalgos, we can get a little bit of code out of the tempita file.