-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
catch complex nan in util.is_nan, de-dup+optimize libmissing, tests #24628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24628 +/- ##
==========================================
- Coverage 92.38% 92.36% -0.02%
==========================================
Files 166 166
Lines 52395 52395
==========================================
- Hits 48403 48393 -10
- Misses 3992 4002 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24628 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 166 166
Lines 52379 52379
=======================================
Hits 48386 48386
Misses 3993 3993
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely needs a perf check
prob need to run the whole suite
] | ||
|
||
inf_vals = [ | ||
float('inf'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should np.inf
and np.NINF
be included too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, will add
I'll get that going... I expect a small speedup, but it'll be thoroughly drowned out in asv noise. |
speed up is ok |
Since asvs are going to take a while and be all noise anyways, heres some itimeits in the interim:
|
can you merge master |
asv finished overnight. we need a better way to systematically profile/benchmark cython funcs...
|
could add/change some more benchmarks and make them match cython and/or missing and/or na |
Even if we did that, they would get drowned out by noise in a full run like this (which would take even longer...). I've been kicking around an idea to automatically identify which benchmarks are relevant for a given PR (based on what files/functions it touches), but it won't be happening any time soon. |
thanks ! |
gets rid of is_null_datelike_scalar, which would, among other things, treat
np.float64('-0.0')
asiNaT
.Some overlap with #24619, merge conflicts should be small or zero.
git diff upstream/master -u -- "*.py" | flake8 --diff