Skip to content

DOC: Update doc description for day_opt in offsets #24602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jan 3, 2019

Follow-up to #24585.

Unlike shift_month, all other descriptions do not
mention support of "None" as a value, since it
is not supported in the other functions.

Follow-up to pandas-devgh-24585.
@gfyoung gfyoung added Docs Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation labels Jan 3, 2019
@gfyoung gfyoung added this to the 0.24.0 milestone Jan 3, 2019
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24602   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52478    52478           
=======================================
  Hits        48483    48483           
  Misses       3995     3995
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 43.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62506ca...a974596. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24602   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52478    52478           
=======================================
  Hits        48483    48483           
  Misses       3995     3995
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 43.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62506ca...a974596. Read the comment docs.

@gfyoung gfyoung merged commit 5ba4337 into pandas-dev:master Jan 3, 2019
@gfyoung gfyoung deleted the tslibs-offsets-day-opt-doc branch January 3, 2019 21:47
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Unlike shift_month, all other descriptions do not
mention support of "None" as a value, since it
is not supported in the other functions.

Follow-up to pandas-devgh-24585.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Unlike shift_month, all other descriptions do not
mention support of "None" as a value, since it
is not supported in the other functions.

Follow-up to pandas-devgh-24585.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Docs Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant