Skip to content

REF: put DatetimeBlock adjacent to DatetimeLikeBlockMixin #24582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Jan 3, 2019

just a straight move?

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Jan 3, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 3, 2019
@jbrockmendel
Copy link
Member Author

yep

@jreback
Copy link
Contributor

jreback commented Jan 3, 2019

k ping on green

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24582 into master will increase coverage by <.01%.
The diff coverage is 94.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24582      +/-   ##
==========================================
+ Coverage   92.36%   92.36%   +<.01%     
==========================================
  Files         166      166              
  Lines       52494    52494              
==========================================
+ Hits        48485    48486       +1     
+ Misses       4009     4008       -1
Flag Coverage Δ
#multiple 90.79% <94.1%> (ø) ⬆️
#single 43.04% <43.43%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 93.79% <94.1%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b91140...e66487e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24582 into master will increase coverage by <.01%.
The diff coverage is 94.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24582      +/-   ##
==========================================
+ Coverage   92.36%   92.36%   +<.01%     
==========================================
  Files         166      166              
  Lines       52494    52494              
==========================================
+ Hits        48485    48486       +1     
+ Misses       4009     4008       -1
Flag Coverage Δ
#multiple 90.79% <94.1%> (ø) ⬆️
#single 43.04% <43.43%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 93.79% <94.1%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b91140...e66487e. Read the comment docs.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit afc2c86 into pandas-dev:master Jan 3, 2019
@jbrockmendel jbrockmendel deleted the again branch January 3, 2019 03:46
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants