Skip to content

REF/TST: Add more pytest idiom to util/test_util #24141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 7, 2018

Also breaks up test_util into multiple test modules by the function or method tested.

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Dec 7, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Dec 7, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@jreback
Copy link
Contributor

jreback commented Dec 7, 2018

looks fine. ping on green.

@gfyoung gfyoung force-pushed the pytest-idiom-test-util branch from d24df8a to 5f45e39 Compare December 7, 2018 18:45
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #24141 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24141      +/-   ##
==========================================
+ Coverage    92.2%    92.2%   +<.01%     
==========================================
  Files         162      162              
  Lines       51700    51700              
==========================================
+ Hits        47670    47671       +1     
+ Misses       4030     4029       -1
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.41% <0%> (-0.1%) ⬇️
pandas/io/json/json.py 93.09% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f492be6...ca6b1ad. Read the comment docs.

@pandas-dev pandas-dev deleted a comment from codecov bot Dec 7, 2018
Also breaks up test_util into multiple test modules
by the function or method tested.
@gfyoung gfyoung force-pushed the pytest-idiom-test-util branch from 5f45e39 to ca6b1ad Compare December 7, 2018 20:35
@jreback jreback merged commit 0a5e747 into pandas-dev:master Dec 7, 2018
@jreback
Copy link
Contributor

jreback commented Dec 7, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the pytest-idiom-test-util branch December 7, 2018 23:52
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Also breaks up test_util into multiple test modules
by the function or method tested.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Also breaks up test_util into multiple test modules
by the function or method tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants