Skip to content

REF: DatetimeIndex constructor fixups #23916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2018
Merged

REF: DatetimeIndex constructor fixups #23916

merged 3 commits into from
Nov 26, 2018

Conversation

jbrockmendel
Copy link
Member

Small non-central pieces broken off from #23675.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 26, 2018 •
edited
Loading

Codecov Report

Merging #23916 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23916   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51500    51500           
=======================================
  Hits        47533    47533           
  Misses       3967     3967
Flag Coverage Δ
#multiple 90.69% <100%> (ø) ⬆️
#single 42.42% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 96.2% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 98.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f02bf2...2e7e5d9. Read the comment docs.

@gfyoung gfyoung added Refactor Internal refactoring of code Datetime Datetime data dtype labels Nov 26, 2018
gfyoung
gfyoung reviewed Nov 26, 2018
View reviewed changes
pandas/tests/scalar/timedelta/test_timedelta.py
@@ -550,7 +550,7 @@ def test_overflow(self):

# mean
result = (s - s.min()).mean()
expected = pd.Timedelta((pd.DatetimeIndex((s - s.min())).asi8 / len(s)
expected = pd.Timedelta((pd.TimedeltaIndex((s - s.min())).asi8 / len(s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this incorrect? How was the mistake caught in the first place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught it when making it warn in #23675.

@jreback jreback added this to the 0.24.0 milestone Nov 26, 2018
@jreback jreback merged commit f1cee69 into pandas-dev:master Nov 26, 2018
@jreback
Copy link
Contributor

jreback commented Nov 26, 2018

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the gentle2 branch November 26, 2018 16:57
@jbrockmendel jbrockmendel mentioned this pull request Nov 26, 2018
Merged
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
REF: DatetimeIndex constructor fixups (pandas-dev#23916)
d9b0bf1
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
REF: DatetimeIndex constructor fixups (pandas-dev#23916)
e444cdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung left review comments

Assignees
No one assigned
Labels
Datetime Datetime data dtype Refactor Internal refactoring of code
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @pep8speaks @jreback @gfyoung