Skip to content

Updated condition to skip for pytables build issue on numpy 1.15 #22098 #22522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 31, 2018
Merged

Updated condition to skip for pytables build issue on numpy 1.15 #22098 #22522

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
966741d
Updated condition to skip for pytables build issue on numpy 1.15 #22098
NikhilKumarM Aug 27, 2018
583211f
Merge branch 'master' of https://github.com/pandas-dev/pandas into br…
NikhilKumarM Aug 27, 2018
cc2ea5b
Updated the message for skipping and added trailing comma
NikhilKumarM Aug 27, 2018
90690bf
Merge branch 'master' of https://github.com/pandas-dev/pandas into br…
NikhilKumarM Aug 28, 2018
d6cba4c
Explicitly checking numpy version 1.15 for pytables test
NikhilKumarM Aug 28, 2018
b252c1e
Merge branch 'master' of https://github.com/pandas-dev/pandas into br…
NikhilKumarM Aug 29, 2018
3337b74
Changed LooseVersion(1.15) to LooseVersion(1.15.0)
NikhilKumarM Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/compat/numpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
_np_version_under1p14 = _nlv < LooseVersion('1.14')
_np_version_under1p15 = _nlv < LooseVersion('1.15')


if _nlv < '1.9':
raise ImportError('this version of pandas is incompatible with '
'numpy < 1.9.0\n'
Expand Down
8 changes: 4 additions & 4 deletions pandas/tests/io/test_pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from pandas import (Series, DataFrame, Panel, MultiIndex, Int64Index,
RangeIndex, Categorical, bdate_range,
date_range, timedelta_range, Index, DatetimeIndex,
isna, compat, concat, Timestamp, _np_version_under1p15)
isna, compat, concat, Timestamp)

import pandas.util.testing as tm
import pandas.util._test_decorators as td
Expand Down Expand Up @@ -2192,9 +2192,9 @@ def test_unimplemented_dtypes_table_columns(self):
pytest.raises(TypeError, store.append, 'df_unimplemented', df)

@pytest.mark.skipif(
not _np_version_under1p15,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't define anything new here, juse use LooseVersion explicity to check for 1.15.0 as this is the only version affected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it. Could you please have a look at it @jreback. let me know if changes required.

reason=("pytables conda build package needs build "
"with numpy 1.15: gh-22098"))
LooseVersion(np.__version__) == LooseVersion('1.15'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need 1.15.0 here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use StrictVersion here?

Copy link
Contributor Author

@NikhilKumarM NikhilKumarM Aug 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I see LooseVersion('1.15') and LooseVersion('1.15.0') are not equal. But, StrictVersion('1.15') and Strict Version('1.15.0') are equal. We can use StrictVersion, in that we can use '1.15' or '1.15.0'. If we are using LooseVersion, then it should be '1.15.0'.

Copy link
Contributor Author

@NikhilKumarM NikhilKumarM Aug 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe to use StrictVersion then?

Copy link
Contributor Author

@NikhilKumarM NikhilKumarM Aug 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made changes with LooseVersion('1.15.0'). I think this will suffice. Please let me know if we have to use StrictVersion instead. @jreback @TomAugspurger

reason=("Skipping pytables test when numpy version is "
"exactly equal to 1.15: gh-22098"))
def test_calendar_roundtrip_issue(self):

# 8591
Expand Down