Implement arithmetic.test_numeric and arithmetic.test_object #22254
Conversation
|
|
||
| @pytest.fixture(params=zeros) | ||
| def zero(request): | ||
| # For testing division by (or of) zero for Index with length 5, this |
There was a problem hiding this comment.
ideall can you come back and put a doc-string on all of the fixtures here (use triple quotes)
| return request.param | ||
|
|
||
|
|
||
| @pytest.fixture(params=[pd.Float64Index(np.arange(5, dtype='float64')), |
There was a problem hiding this comment.
call this something else, idx is too specific a name (and it is used heavily elsewhere)
There was a problem hiding this comment.
Will do in next pass (hopefully tomorrow)
|
|
||
| @pytest.mark.parametrize( | ||
| 'box, assert_func', | ||
| [(Series, tm.assert_series_equal), |
There was a problem hiding this comment.
note that we now have tm.assert_equal to solve cases like this (certainly can change later though)
There was a problem hiding this comment.
Yep, I'm looking forward to getting rid of this hack
|
|
||
| @pytest.mark.parametrize('op', ['__add__', '__radd__', | ||
| '__sub__', '__rsub__']) | ||
| @pytest.mark.parametrize('tz', [None, 'Asia/Tokyo']) |
There was a problem hiding this comment.
note to use the tz fixtures
| # ------------------------------------------------------------- | ||
| # Timezone-Centric Tests | ||
|
|
||
| def test_operators_datetimelike_with_timezones(self): |
There was a problem hiding this comment.
maybe move to a separate test_timezones.py (later is ok too)
| pd.Int64Index(np.arange(5, dtype='int64')), | ||
| pd.RangeIndex(5)], | ||
| ids=lambda x: type(x).__name__) | ||
| def idx(request): |
There was a problem hiding this comment.
duplicate of conftest (maybe that's ok)
There was a problem hiding this comment.
Yah, I'm not going to worry about fixture duplication until after tests.test_arithmetic is moved to tests.arithmetic.test_timedelta64
|
|
||
| class TestDivisionByZero(object): | ||
|
|
||
| def test_div_zero(self, zero, idx): |
There was a problem hiding this comment.
are these specific to Index tests? or are they moving so that you can consolidate later?
There was a problem hiding this comment.
or are they moving so that you can consolidate later?
Yes, very nearly everything in this PR is moved with minimal changes so they can be de-duplicated and parametrized/fixturized in an upcoming pass.
Codecov Report
@@ Coverage Diff @@
## master #22254 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 169 169
Lines 50683 50683
=======================================
Hits 46666 46666
Misses 4017 4017
Continue to review full report at Codecov.
|
|
thanks |
Also move a bunch more dt64 and td64 tests that have been hiding. For the most part this doesn't do any of the parametrizing over box-classes; that and a bunch of de-duplication are for the next pass.