Skip to content

Separate out internals.concat, internals.managers #22028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

jbrockmendel
Copy link
Member

Follow-up to #22014.

Moved get_blockno_placements to libinternals since a) its a natural fit anyway and b) it is needed in both concat and managers and I didn't want to runtime-import it.

The only non-cut/paste edit is a change of isinstance(self.block, ExtensionBlock) to self.block.is_extension

__init__ namespace is big in part because io.packers uses getattr(internals, name) and is just really tightly intertwined with internals.

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #22028 into master will increase coverage by <.01%.
The diff coverage is 96.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22028      +/-   ##
==========================================
+ Coverage   91.99%      92%   +<.01%     
==========================================
  Files         168      170       +2     
  Lines       50597    50601       +4     
==========================================
+ Hits        46549    46553       +4     
  Misses       4048     4048
Flag Coverage Δ
#multiple 90.4% <96.88%> (ø) ⬆️
#single 42.2% <68.1%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/__init__.py 100% <100%> (+3.11%) ⬆️
pandas/core/internals/managers.py 96.52% <96.52%> (ø)
pandas/core/internals/concat.py 98.37% <98.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716efd3...f7490a9. Read the comment docs.

@TomAugspurger TomAugspurger added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Jul 23, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jul 23, 2018
@jreback jreback merged commit 1b5b813 into pandas-dev:master Jul 24, 2018
@jreback
Copy link
Contributor

jreback commented Jul 24, 2018

yep, thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the internals3 branch July 26, 2018 16:22
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants