Separate out internals.concat, internals.managers #22028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #22014.
Moved
get_blockno_placements
to libinternals since a) its a natural fit anyway and b) it is needed in both concat and managers and I didn't want to runtime-import it.The only non-cut/paste edit is a change of
isinstance(self.block, ExtensionBlock)
toself.block.is_extension
__init__
namespace is big in part becauseio.packers
usesgetattr(internals, name)
and is just really tightly intertwined with internals.