CLN: Unreachable code, Boolean comparison, duplicate functions

[mroeschke]

Breaking up #21974.

This batch is:

• Unreachable code
• Redefined function (in asv)
• Boolean equality comparison

[jbrockmendel]

LGTM.

@jorisvandenbossche IIRC you wanted to keep numpydoc changes separate from others?

[gfyoung]

Yikes! That's pretty bad...

[jorisvandenbossche]

IIRC you wanted to keep numpydoc changes separate from others?

Yes, numpydoc is vendored. So if we want to make changes to it, it should be done upstream.

[jreback]

lgtm. not sure by @jorisvandenbossche comments

ok to make the numpydoc change here and push upstream as well?

[jorisvandenbossche]

No, no reason to do it here. That only makes updating our version with upstream afterwards harder.

[jreback]

@mroeschke ok then if you'd pull the numpydoc changes out

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@27ebb3e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #21985   +/-   ##
=========================================
  Coverage          ?   91.97%           
=========================================
  Files             ?      166           
  Lines             ?    50328           
  Branches          ?        0           
=========================================
  Hits              ?    46287           
  Misses            ?     4041           
  Partials          ?        0

Flag	Coverage Δ
#multiple	90.36% <ø> (?)
#single	42.23% <ø> (?)

Impacted Files	Coverage Δ
pandas/core/indexes/period.py	93.39% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ebb3e...1a5a486. Read the comment docs.

[jorisvandenbossche]

Thanks!