Skip to content

ENH: Adding pd.__git_version__ to point to git sha commit (#21295) #21680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

ENH: Adding pd.__git_version__ to point to git sha commit (#21295) #21680

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bad820e
ENH: Adding pd.__git_version__ to point to git sha commit (#21295)
atulagrwl Jun 29, 2018
94e9e41
ENH: Using .get instead of directly accessing (#21295)
atulagrwl Jun 30, 2018
8a4563c
ENH: Fixing typo in previous commit (#21295)
atulagrwl Jun 30, 2018
162985b
TST: Adding test for __git_version__ (#21295)
atulagrwl Jun 30, 2018
4808f52
TST: Adding whatsnews entry and adding issue number in test (#21295)
atulagrwl Jul 1, 2018
249d843
TST: Fixing PEP8 error (#21295)
atulagrwl Jul 1, 2018
0406aa7
Merge branch 'master' into git_version
atulagrwl Jul 9, 2018
756084a
Merge branch 'master' of https://github.com/pandas-dev/pandas into gi…
atulagrwl Jul 26, 2018
a78165d
TST: Moving comment of Issue number below def as per review notes (#2…
atulagrwl Jul 26, 2018
9421725
Fixing whatsnew entry to specify attribute rather than method.
atulagrwl Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
from ._version import get_versions
v = get_versions()
__version__ = v.get('closest-tag', v['version'])
__git_version__ = v['full-revisionid']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won’t work for released version
use .get

pls add a test for this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding test to check if it returns valid sha should be okay?

del get_versions, v

# module level doc-string
Expand Down