Two tests didn't properly assert an exception was raised. Fixed. #21409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jun 10, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -191,6 +191,5 @@ Other | |||
| ^^^^^ | |||
|
|
|||
| - :meth: `~pandas.io.formats.style.Styler.background_gradient` now takes a ``text_color_threshold`` parameter to automatically lighten the text color based on the luminance of the background color. This improves readability with dark background colors without the need to limit the background colormap range. (:issue:`21258`) | |||
| - | |||
| - | |||
| - fixed two test cases which asserted an exception message but failed to make sure that an exception was actually raised | |||
There was a problem hiding this comment.
not necessary for test changes
| @@ -34,10 +34,9 @@ def test_buffer_overflow(self): | |||
| cperr = 'Buffer overflow caught - possible malformed input file.' | |||
|
|
|||
| for malf in (malfw, malfs, malfl): | |||
| try: | |||
| with pytest.raises(pd.errors.ParserError) as excinfo: | |||
There was a problem hiding this comment.
can u parametrize this test
There was a problem hiding this comment.
Parametrized in f47437e.
Codecov Report
@@ Coverage Diff @@
## master #21409 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 153 153
Lines 49600 49596 -4
==========================================
- Hits 45580 45576 -4
Misses 4020 4020
Continue to review full report at Codecov.
|
added 2 commits
June 10, 2018 17:47
This reverts commit ded6a05. Whatsnew entries are not required for test changes.
gfyoung
approved these changes
Jun 10, 2018
|
thanks @akaihola; slight change to use pytest ids, otherwise nice catch! keep em coming! |
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff