Parametrization of indexes/test_base #4 #20979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
changed the title
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #20979 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 153 153
Lines 49490 49490
=======================================
Hits 45445 45445
Misses 4045 4045
Continue to review full report at Codecov.
|
jreback
approved these changes
May 9, 2018
| u" dtype='object', length=300)") | ||
|
|
||
| assert coerce(idx) == expected | ||
| (pd.Index([u'あ', u'いい', u'ううう'] * 100), |
There was a problem hiding this comment.
later on would move these repr tests to a separate test file (in future PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress towards #20812
This should be it for parametrizing tests. Plan is to look at and clean up fixtures after this